node-mongodb-native icon indicating copy to clipboard operation
node-mongodb-native copied to clipboard

test(NODE-5788): rework change stream close rejection test

Open nbbeeken opened this issue 1 year ago • 0 comments

Description

What is changing?

  • The change stream tests removed were flaky, I recaptured what I think is the intended behavior, pending promises are rejected by a close call
  • Further clarity will be worked on in NODE-5221
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Reduce flaky tests.

Double check the following

  • [x] Ran npm run check:lint script
  • [x] Self-review completed using the steps outlined here
  • [x] PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • [x] Changes are covered by tests
  • [x] New TODOs have a related JIRA ticket

nbbeeken avatar Sep 11 '24 17:09 nbbeeken