node-mongodb-native icon indicating copy to clipboard operation
node-mongodb-native copied to clipboard

fix(NODE-5723): emit TopologyDescriptionChangedEvent just before close

Open W-A-James opened this issue 1 year ago • 2 comments

Description

What is changing?

  • Unskip Topology life cycle tests
  • Remove modified logging spec tests
  • Pull in updated logging-loadbalancer tests
  • Pull in new monitoring tests
  • Fix bug in test runner that was exiting on encountering a single SDAM event
  • Emit TopologyDescriptionChangedEvent transitioning to Unknown Topology type just before close
Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-5723 / DRIVERS-2711

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • [X] Ran npm run check:lint script
  • [X] Self-review completed using the steps outlined here
  • [X] PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • [X] Changes are covered by tests
  • [ ] New TODOs have a related JIRA ticket

W-A-James avatar Jan 17 '24 20:01 W-A-James

~Note: getting spec test failures, but they disappear when only running the tests in question.~

Failures were coming from old modified spec tests that have now been removed.

W-A-James avatar Jan 18 '24 19:01 W-A-James

Note: this branch was rebased against #4089 which implements the UTR changes introduced in DRIVERS-2875

W-A-James avatar Apr 19 '24 21:04 W-A-James