mongodb-atlas-kubernetes icon indicating copy to clipboard operation
mongodb-atlas-kubernetes copied to clipboard

Refactor searchindex translation layer

Open josvazg opened this issue 1 year ago • 2 comments

All Submissions:

  • [X] Have you signed our CLA?

josvazg avatar May 23 '24 17:05 josvazg

The refactor has messed up the unit tests due to the initialisation of the service. I need to figure out a way to do teh initialisation that works for production and test and is acceptably neat.

josvazg avatar May 23 '24 17:05 josvazg

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/1b60a9ef375e6e4efb9d450dd108cda72a427524

github-actions[bot] avatar May 24 '24 11:05 github-actions[bot]

I'd only move mocks to internal/mocks/translation 🙈 . I'd also think about use mockery instead of manually add these mocks, the same way is done for the SDK

Lets make a final decision, I volunteer to make the refactors whatever the decision is finally.

josvazg avatar Jun 14 '24 11:06 josvazg