mongo icon indicating copy to clipboard operation
mongo copied to clipboard

Published 20 hours ago • verified publisher icon mongodb

SERVER-68578

Open SurfinScott opened this issue 2 years ago • 1 comments

There's a single reference to appendSystemDetails in generic_servers.cpp. It makes sense to have the function return an un-nested BSON object in the same getSystemFoo() and reply.setFoo() style instead of modifying its referenced object argument.

SurfinScott avatar Aug 05 '22 14:08 SurfinScott

I don't agree with this change to appendSystemDetails. There's a field nesting bug to fix, but I don't think changing the append model of this member function is necessary to fix it.

BillyDonahue avatar Aug 08 '22 17:08 BillyDonahue

Agree with @BillyDonahue - updated commit updates 1 file and reverts 1 file @sgolemon whatever is easiest is fine by me.

SurfinScott avatar Aug 15 '22 17:08 SurfinScott

evergreen patch

sgolemon avatar Aug 22 '22 14:08 sgolemon

@SurfinScott Cool cool. I'll get it landed and sort out backports then. Thanks for the work!

sgolemon avatar Aug 22 '22 14:08 sgolemon

Closed by commit b00a1cb333043adfd4d0867ec01d9b699a17cf6a

sgolemon avatar Aug 22 '22 21:08 sgolemon