mongo-python-driver icon indicating copy to clipboard operation
mongo-python-driver copied to clipboard

PYTHON-4227 Unified tests: Advance cluster_time of ClientSessions after initialData creation

Open caseyclements opened this issue 1 year ago • 2 comments
trafficstars

Changes

After initialData is added in test.unified_format's run_scenario, we get the $clusterTime from the server, and add this to each of the ClientSession entities before further operations.

Motivation for the change.

DRIVERS-2816

Here is the pertinent section of the specifications

caseyclements avatar Apr 17 '24 15:04 caseyclements

I'm investigating the new failure that popped up. I can reproduce locally.

FAILURE: pymongo.errors.OperationFailure: PlanExecutor error during aggregation :: caused by :: indexes of target collection db0.coll0 changed during processing., 

self = <test.test_crud_unified.TestUnifiedDbAggregateWriteReadPreference testMethod=test_Database-level_aggregate_with_$out_includes_read_preference_for_5_0+_server>

caseyclements avatar Apr 17 '24 16:04 caseyclements

That's https://jira.mongodb.org/browse/PYTHON-4356

blink1073 avatar Apr 17 '24 17:04 blink1073

@ShaneHarvey, @blink1073 test.test_transactions_unified.TestUnifiedMongosUnpin.test_unpin_after_TransientTransactionError_error_on_abort is still failing intermittently. This PR had removed the skip. Should I put it back on?

caseyclements avatar Apr 22 '24 23:04 caseyclements

Should I put it back on?

Yeah, apparently https://jira.mongodb.org/browse/PYTHON-4182 was unrelated, I unblocked it and put it in scheduled.

blink1073 avatar Apr 23 '24 00:04 blink1073

Merging so we can check the waterfall afterward.

blink1073 avatar Apr 24 '24 11:04 blink1073