mongo-cxx-driver icon indicating copy to clipboard operation
mongo-cxx-driver copied to clipboard

Published 20 hours ago • verified publisher icon mongodb

Reduce Warnings - Address warnings in examples and redundant recompilations

Open eramongodb opened this issue 5 months ago • 0 comments

Verified by this patch.

Addresses 583 Clang warnings (157 unique) and 198 (7 unique) MSVC warnings relating to those emitted by examples (as part of CXX-2827). If a given warning was present in examples, this PR addresses it across all code for consistency.

404 Clang warnings and 191 MSVC warnings are addressed simply by reducing redundant recompilation of the new client_helpers and spec_test_common object library components by various mongocxx test executables. None of these warnings were unique: they were just noisy repetition of the same warning. This refactor should reduce both the warning count and the overall compilation time for mongocxx test executables.

Warnings pertaining to __cdecl are deferred to CXX-3092.

Warnings related to _CRT_SECURE_NO_WARNINGS with MSVC (getenv and gmtime) are left as-is. Feedback on how to approach these warnings (disable? #if blocks? a platform-dependent BSONCXX_PRIVATE_GETENV macro?) is welcome.

eramongodb avatar Aug 29 '24 18:08 eramongodb