mongo-csharp-driver
mongo-csharp-driver copied to clipboard
Skunkworks: Update .editorconfig to match coding convention for C# driver
This PR updates the .editorconfig file to match the coding conventions used in the C# driver. The changes eliminated something like 95% of the 10,000+ errors from running code analysis on this project. Tweaks were made to the source code to address the remaining errors. These changes consisted of fixing portions of the code that were inconsistent with the conventions used elsewhere and removing suppressions of warnings that didn't exist in the first place. (Perhaps some of these were genuine warnings in earlier C# versions, but more recent compiler versions may be smart enough to recognize that these warnings were superfluous.) With the entirety of this PR in place, code analysis passes on the project with no errors.
I've set the severity for a number of the analysis rules to refactoring
, which means that no error is produced for violating them, but IntelliSense offers you the option to change them in the code editor. At least some of these might make sense to consider enabling in the future, given that they would represent code quality improvements and modernizations to take full advantage of some of the features added in more recent C# versions. However, given that this PR is already not tiny and Skunkworks is of limited duration, I'm leaving them disabled for now.