laravel-mongodb icon indicating copy to clipboard operation
laravel-mongodb copied to clipboard

Allow to sync a single model instance

Open mrneatly opened this issue 3 years ago • 6 comments

Fix sync() method not handling properly single model's instances passed via $ids argument

mrneatly avatar May 28 '22 08:05 mrneatly

Issue #2395

mrneatly avatar May 28 '22 08:05 mrneatly

Codecov Report

Merging #2396 (c5cdadb) into master (f4c448f) will decrease coverage by 0.04%. The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #2396      +/-   ##
============================================
- Coverage     87.62%   87.57%   -0.05%     
- Complexity      676      677       +1     
============================================
  Files            31       31              
  Lines          1551     1553       +2     
============================================
+ Hits           1359     1360       +1     
- Misses          192      193       +1     
Impacted Files Coverage Δ
src/Relations/BelongsToMany.php 86.00% <50.00%> (-0.74%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4c448f...c5cdadb. Read the comment docs.

codecov-commenter avatar May 28 '22 08:05 codecov-commenter

@mrneatly do you have plans to continue work with PR?

Smolevich avatar Sep 01 '22 10:09 Smolevich

@Smolevich sure, I just need to figure out what's wrong with the code style. As I know from #2438, there were some issues with StyleCI. Is it somehow related to the result of php-cs-fixer in this PR?

mrneatly avatar Sep 01 '22 10:09 mrneatly

I can't push changes to your fork as you haven't given any permissions.

You don't have permissions to push to 'mrneatly/laravel-mongodb' on GitHub. Would you like to create a fork and push to it instead?

divine avatar Sep 01 '22 13:09 divine

Hey @divine I've sent you an invitation to my fork

mrneatly avatar Sep 03 '22 14:09 mrneatly

Hey @divine I've sent you an invitation to my fork

@mrneatly what is the actual status of this work?

Smolevich avatar Nov 20 '22 09:11 Smolevich