laravel-mongodb icon indicating copy to clipboard operation
laravel-mongodb copied to clipboard

add validate instaceof Model and fix current in sync method for Hybrid relation

Open juniohyago opened this issue 3 years ago • 6 comments

juniohyago avatar Jun 21 '21 20:06 juniohyago

Hello,

Add tests, please.

Thanks!

divine avatar Jun 26 '21 09:06 divine

Hello, tests ok thanks

juniohyago avatar Jul 02 '21 12:07 juniohyago

Hello,

Tests are failing, also fix php-cs-fixer suggestion.

Thanks!

divine avatar Jul 02 '21 12:07 divine

hello, I haven't found a model for many to many hybrids, do I need to create this?

juniohyago avatar Jul 02 '21 12:07 juniohyago

Hello, Tests are ok now, Thanks!

juniohyago avatar Jul 02 '21 19:07 juniohyago

Codecov Report

Merging #2276 (26e77f6) into master (6aa6ad1) will increase coverage by 0.26%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2276      +/-   ##
============================================
+ Coverage     88.12%   88.38%   +0.26%     
- Complexity      664      665       +1     
============================================
  Files            33       33              
  Lines          1566     1567       +1     
============================================
+ Hits           1380     1385       +5     
+ Misses          186      182       -4     
Impacted Files Coverage Δ
src/Relations/BelongsToMany.php 87.25% <100.00%> (+1.11%) :arrow_up:
src/Eloquent/Model.php 94.26% <0.00%> (+0.63%) :arrow_up:
src/Eloquent/HybridRelations.php 96.15% <0.00%> (+2.56%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6aa6ad1...26e77f6. Read the comment docs.

codecov-commenter avatar Jul 03 '21 11:07 codecov-commenter