vscode icon indicating copy to clipboard operation
vscode copied to clipboard

fix: send 1 notification when switching connection

Open SethFalco opened this issue 3 years ago • 4 comments

Description

Previously, when one had 2 connections, switching created 2 notifications.

This isn't a major problem, but is a little annoying.

This instead adds a quiet argument to #disconnect, and uses this argument when switching to skip the notification for disconnecting.

Checklist

  • [ ] New tests and/or benchmarks are included
  • [ ] Documentation is changed or added

Not sure if this PR requires them as this only really updates the use of showInformationMessage which is mocked in the tests anyway.

Motivation and Context

  • [ ] Bugfix
  • [ ] New feature
  • [ ] Dependency update
  • [x] Misc

Open Questions

Happy to discuss UX if you have any feedback/opinions.

Types of changes

  • [ ] Backport Needed
  • [x] Patch (non-breaking change which fixes an issue)
  • [ ] Minor (non-breaking change which adds functionality)
  • [ ] Major (fix or feature that would cause existing functionality to change)

SethFalco avatar May 28 '22 07:05 SethFalco

I noticed you merged one of my PRs! Just wanted to apologize for putting off these 2 that are still pending some work before they're ready to be reviewed. I'll try to get back to them tomorrow if I have time!

SethFalco avatar Jul 21 '22 21:07 SethFalco