electron-squirrel-startup
electron-squirrel-startup copied to clipboard
On --squirrel-updated event, don't recreate shortcut if not already there
If the user has deleted the desktop shortcut, at the moment it's recreating it every time the app updates.
atom/atom checks if the desktop shortcut is there on --squirrel-updated
, and if not (meaning it has been deleted), don't recreate it (actually, they recreate it then delete it).
See https://github.com/atom/atom/blob/master/src/main-process/squirrel-update.coffee#L100-L106
Would it make sense to implement this logic by default?
@romaincointepas Sounds good to me! Would you be interested in submitting a PR for this?
I might have some time within the next few weeks to PR this if there's still interest in it 😸.
I would love this as well. How's that fork coming @ccnokes?
@gschier hmmm..... I can't remember 😸 . I think that fork is probably good to go, it just needs to be tested, and then PR it. I probably won't have time to revisit this till next year though 😢 . Feel free to fork my fork or copy and paste into your own fork (assuming it works) or whatever though 👍 .