electron-squirrel-startup icon indicating copy to clipboard operation
electron-squirrel-startup copied to clipboard

Code quits once it finishing handling squirrel flag

Open trodi opened this issue 6 years ago • 0 comments

The usage documentation shows calling app.quit() after requireing electron-squirrel-startup, however, the code calls quit itself. This is misleading. If you run your own code on one of these flags after requireing electron-squirrel-startup, the app will quit from under you. The documentation should match the code. It would be nice to only optionally quit or not quit at all for flexibility.

Usage Docs

if(require('electron-squirrel-startup')) app.quit();

Source Code

https://github.com/mongodb-js/electron-squirrel-startup/blob/29221a02c38bc43655e5c67e189e2a25105753f6/index.js#L21

trodi avatar Jan 18 '19 18:01 trodi