compass icon indicating copy to clipboard operation
compass copied to clipboard

Published 20 hours ago • verified publisher icon mongodb-js

feat(compass-aggregations): Update saved aggregations to open as popover COMPASS-5852

Open Anemy opened this issue 2 years ago • 2 comments

COMPASS-5852

This PR updates the saved aggregations view to open as a popover, previously it would open as a panel from the left.

A few driveby updates:

  • Updated the title and button in the panel to leafygreen.
  • Added an empty state (screenshot below).
  • A bit of renaming: previously the saved aggregations panel was named save-pipeline.jsx, now it is saved-pipelines.tsx.
  • (bugfix) Previously if a user had a lot of saved aggregations the panel would overflow the top level container, now it scrolls nicely

Before: Screen Shot 2022-08-15 at 3 47 23 PM

After: Screen Shot 2022-08-15 at 3 47 39 PM

With lots of saved aggregations: Screen Shot 2022-08-15 at 3 32 10 PM

Video:

https://user-images.githubusercontent.com/1791149/184723351-a8095c53-f8f5-4c73-b048-59f740ce5f42.mp4

Empty state before: Screen Shot 2022-08-15 at 5 25 17 PM

Empty state after: Screen Shot 2022-08-15 at 5 25 26 PM

Anemy avatar Aug 15 '22 21:08 Anemy

Noticed the popover closes when the modal confirmation opens, going to bring this with Claudia and look at what behavior we want here. Maybe we can remove the confirmation all together.

Anemy avatar Aug 15 '22 22:08 Anemy

@Anemy @Sgrinfy given that we are touching this component, should we consider making it clear that those are the pipelines for the current collection and not all of them, maybe by tweaking the copy a bit?

mmarcon avatar Aug 16 '22 06:08 mmarcon