mongo-express icon indicating copy to clipboard operation
mongo-express copied to clipboard
verified publisher icon mongo-express

chore: update Express.js to v5

Open rtritto opened this issue 3 years ago • 7 comments

This change is Reviewable

Migrate to v5

rtritto avatar Sep 01 '22 12:09 rtritto

Correctly rebased with master. FYI @shakaran

rtritto avatar Sep 09 '22 21:09 rtritto

Correctly rebased with master. FYI @shakaran

it seems that still fail for the pipelines

shakaran avatar Sep 09 '22 22:09 shakaran

Correctly rebased with master. FYI @shakaran

it seems that still fail for the pipelines

I know, that fix works only with express v5. My base idea is to wait a stable/rc express v5 to update the dependency. By this way, we should have less conflicts with rebases/synch.

rtritto avatar Sep 09 '22 23:09 rtritto

@rtritto this need rebase or update maybe

shakaran avatar Dec 07 '23 16:12 shakaran

@rtritto any update with this?

shakaran avatar Feb 17 '24 15:02 shakaran

v5 isn't updated with v4. Before merge, I would wait for the v5 to become stable. express seems not mantained so we should consider to migrate to fastify. I did this branch https://github.com/mongo-express/mongo-express/tree/fastify-migration as draft.

rtritto avatar Feb 20 '24 18:02 rtritto

v5 isn't updated with v4. Before merge, I would wait for the v5 to become stable. express seems not mantained so we should consider to migrate to fastify. I did this branch https://github.com/mongo-express/mongo-express/tree/fastify-migration as draft.

In that versión, I see that we lost the support for swigEngine, could you add it too and make a PR rebased?

shakaran avatar Feb 20 '24 18:02 shakaran