mongo-express-docker
mongo-express-docker copied to clipboard
mongo-express
Support ME_CONFIG_MONGODB_URL
In order to support ME_CONFIG_MONGODB_URL, variable ME_CONFIG_MONGODB_SERVER must first be set to empty string. However, the docker-entrypoint is still trying to connect to the empty string. This fix stops the docker-entrypoint from connecting to an empty string.
Yeah, I like that. Thanks @somdoron.
On Mon, Jun 3, 2019, 5:10 PM Tianon Gravi [email protected] wrote:
This seems sane to me -- any thoughts @knickers https://github.com/knickers?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mongo-express/mongo-express-docker/pull/31?email_source=notifications&email_token=AAJF252Z2HH3EGZKMBK7KT3PYWQFFA5CNFSM4HNCWBKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW26B5A#issuecomment-498458868, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJF25YOWT637T7IHDZHBFTPYWQFFANCNFSM4HNCWBKA .
I had just made the exact same pull-request (https://github.com/mongo-express/mongo-express-docker/pull/47)... why is this not being merged? Because there are no more releases for mongo-express?
Since the next version to be released is 1.0.0 (if it ever comes out), it might be the moment to also stop setting ME_CONFIG_MONGODB_SERVER="mongo". That default setting makes less sense with this pull-request: ME_CONFIG_MONGODB_SERVER is allowed to be empty.
ME_CONFIG_MONGODB_SERVER it's not valid (deprecated/unsafe old logic) because it's removed in https://github.com/mongo-express/mongo-express/pull/957.
FYI @BlackthornYugen @shakaran @tianon
