money icon indicating copy to clipboard operation
money copied to clipboard
verified publisher icon moneyphp

Switch Psalm with PHPStan

Open ruudk opened this issue 1 year ago • 3 comments

Currently, Psalm blocks testing this on PHP 8.4 #796 .

I also wonder why the package uses Psalm, as PHPStan feels much more alive than Psalm.

ruudk avatar Sep 12 '24 06:09 ruudk

Why would Psalm be blocking that? I don't see any failed tests because of it.

frederikbosch avatar Sep 12 '24 09:09 frederikbosch

Because I added --platform-ignore-reqs=php to the PR in the meantime.

ruudk avatar Sep 12 '24 09:09 ruudk

Oh, I did not do a good review then, that's a blocker.

frederikbosch avatar Sep 12 '24 09:09 frederikbosch

It's not a bad idea to switch to PHPStan. The contributions to Psalm are not what it has been, while PHPStan has recently released version 2. There is also no urgency in the Psalm project to support PHP 8.4 which stops us at the moment from supporting 8.4.

So, if anyone would like to contribute the switch, I would love to help. I lack the time at the moment to create the PR myself.

frederikbosch avatar Nov 22 '24 09:11 frederikbosch

@frederikbosch 🫡 challenge accepted

ruudk avatar Nov 22 '24 10:11 ruudk