monero icon indicating copy to clipboard operation
monero copied to clipboard

Published 20 hours ago • verified publisher icon monero-project

Fix lmdb txn commit code

Open vtnerd opened this issue 10 months ago • 3 comments

I added LMDB code to monero core a while ago. The only project (afaik) using it is LWS. I found this bug in the commit code - commit can fail with a resize request too.

If anyone thinks this code should be removed and put into LWS let me know shortly. I thought perhaps this could be used to replace existing LMDB code, but it looks unlikely at this point.

vtnerd avatar Apr 14 '24 18:04 vtnerd

LGTM semantically and syntactically.

I will approve this in few days if anyone not raise any issues about having this here.

0xFFFC0000 avatar May 31 '24 16:05 0xFFFC0000

Embarrassing, this still has a bug in it. I will post an updated version, with an additional fix for the commit function.

vtnerd avatar Jun 04 '24 22:06 vtnerd

@0xFFFC0000 sorry for the changes, but I added a few more. If they get accepted, I will do a release branch version too. LWS is a little "shaky" without the changes.

vtnerd avatar Jun 04 '24 23:06 vtnerd