monero icon indicating copy to clipboard operation
monero copied to clipboard

Skip privacy networks (on tx sends) that don't have outgoing connections [0.18]

Open vtnerd opened this issue 10 months ago • 4 comments

This will check if the privacy network has outgoing connections before attempting to send over that network. The primary difference is that this will allow sending txes over Tor if I2P has no outgoing connections.

This differs from the PR yesterday in that it checks the outgoing checks directly instead of the count reported by the noise code.

vtnerd avatar Mar 29 '24 22:03 vtnerd

I wanted to make this is a draft, oh well @selsta I will post the master version if this patch works.

vtnerd avatar Mar 29 '24 22:03 vtnerd

Thank you 🙏

nahuhh avatar Mar 30 '24 18:03 nahuhh

i first became aware of this bug after @nahuhh mentioned having similar issues with i2p / confirmed it was happening (along with the i2p phantom/double port issue), this is a very important fix. if you consider that i am hosting public nodes who can without notice behave like a malicious one not broadcasting peoples transactions it is quite stressful. will be testing this

plowsof avatar Mar 30 '24 19:03 plowsof

I'll test for a few days and report back. I run i2p on a different device, so should catch any issues.

nahuhh avatar Apr 26 '24 01:04 nahuhh

tested for a couple weeks on android with external i2p LGTM

nahuhh avatar May 11 '24 16:05 nahuhh