monero icon indicating copy to clipboard operation
monero copied to clipboard

Published 20 hours ago • verified publisher icon monero-project

epee: cleanup string_tools

Open 0xFFFC0000 opened this issue 1 year ago • 2 comments

  1. Use boost::filesystem for already available operations.
  2. Use boost::string for already available operations.
  3. ~~Fix the inconsistent indentation.~~

0xFFFC0000 avatar Feb 03 '24 11:02 0xFFFC0000

Pointless busywork IMHO. Adds to the review load, replaces code that's worked so far with code that hasn't. If it actually fixes anything, it should be mentioned in the commit message.

moneromooo-monero avatar Feb 14 '24 08:02 moneromooo-monero

Changelog:

  1. Cleaned unnecessary windows function change.
  2. Rebased to upstream/master.
  3. Changed the PR name to reflect our rules for PR names.

0xFFFC0000 avatar Mar 15 '24 11:03 0xFFFC0000