monero icon indicating copy to clipboard operation
monero copied to clipboard

"Dev" install target

Open jbakosi opened this issue 2 years ago • 0 comments

I use monero and monero-cpp as external libs in an app via cmake's ExternalProject_Add() functionality, which runs cmake, followed by make install on external libs.

Currently, monero's install target installs the following:

-- Install configuration: "RELEASE"
-- Installing: ${CMAKE_INSTALL_PREFIX}/lib/liblmdb.a
-- Installing: ${CMAKE_INSTALL_PREFIX}/lib/libeasylogging.a
-- Installing: ${CMAKE_INSTALL_PREFIX}/lib/libepee.a
-- Installing: ${CMAKE_INSTALL_PREFIX}/lib/libepee_readline.a
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-wallet-rpc
-- Installing: ${CMAKE_INSTALL_PREFIX}/include/wallet/api/wallet2_api.h
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-wallet-cli
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-gen-trusted-multisig
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-gen-ssl-cert
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monerod
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-blockchain-import
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-blockchain-export
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-blockchain-mark-spent-outputs
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-blockchain-usage
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-blockchain-ancestry
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-blockchain-depth
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-blockchain-stats
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-blockchain-prune-known-spent-data
-- Installing: ${CMAKE_INSTALL_PREFIX}/bin/monero-blockchain-prune

This is a good "user" install target, but to use monero as a library, I find that I need to apply this patch to create more files to be installed. (This way I can build and install monero and monero-cpp separately, which is easier to work with as the build is more modular.)

I wonder if it makes sense to contribute this back as a "dev" install target. It could be done optionally, triggered by some cmake variable that's off by default.

jbakosi avatar Aug 19 '22 18:08 jbakosi