monero icon indicating copy to clipboard operation
monero copied to clipboard

Bump Gitian build instructions to v0.18.1.0

Open sethforprivacy opened this issue 1 year ago • 3 comments

sethforprivacy avatar Jul 18 '22 12:07 sethforprivacy

Patch looks ok. I wonder if we should instead make the instructions to set a shell variable for the version instead, so we only need to update the doc in one place and just use the variable everywhere else?

VERSION=v0.18.0.0
./dockrun.sh $VERSION

etc...

hyc avatar Jul 18 '22 13:07 hyc

@hyc I think that's the better option and that's how it's done in the main gitian README

jeffro256 avatar Jul 18 '22 14:07 jeffro256

Patch looks ok. I wonder if we should instead make the instructions to set a shell variable for the version instead, so we only need to update the doc in one place and just use the variable everywhere else?

VERSION=v0.18.0.0
./dockrun.sh $VERSION

etc...

Will make and push that change now, good suggestion.

sethforprivacy avatar Jul 18 '22 14:07 sethforprivacy