monero-site
monero-site copied to clipboard
Fix a small typo, a wording, and a hyperlink
This PR fixes a small typo, a wording, and a hyperlink
Also, it fixes the "the announcement post." on the "P2Pool: The best of both solo and pool mining" at https://www.getmonero.org/get-started/mining/, which currently redirects to https://www.getmonero.org/get-started/mining/%7B%7B%20site.baseurl%20%7D%7D/2021/10/05/p2pool-released.html
Deploy Preview for barolo-time-757cf9 ready!
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | 0342af375fa9c20bf5b73efb1f134298b4891232 |
Latest deploy log | https://app.netlify.com/sites/barolo-time-757cf9/deploys/62a8083b167976000856ed69 |
Deploy Preview | https://deploy-preview-1985--barolo-time-757cf9.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
I think we already have such split keys i.e. https://github.com/monero-project/monero-site/blob/abcf12c4ccac3e48bb4ff178f18bb8a95d94b029/_i18n/en.yml#L334
For the record, the broken link has been fixed in #1959, without splitting the string.
@netrik182:
I think we already have such split keys
We started using such split keys before translations were done one string at a time in Weblate. Translators had more context, since they edited the whole file. So that's not a good precedent.
@selsta Thanks for considering translation issues. Possible translation issues include:
- Some languages might require a different noun case after, or instead of, the preposition
in
. - One might want to rephrase "More details in the announcement post" as "See the announcement post for more details", for example, when that's more natural in the target language.
I've worked with a commercial version of Weblate which automatically put all hyperlink code in a placeholder, which would avoid any accidental changes, but on the other hand:
- I don't know how much work it would be to set that up.
- It might be hard to make this compatible with YAML.
- Sometimes I want to be able to edit a link as a translator, e.g. a link in a user guide to a third-party page that has been translated.