monero-gui icon indicating copy to clipboard operation
monero-gui copied to clipboard

RemoteNodeList, RemoteNodeDialog: different remote node for each network type; implement labels

Open elibroftw opened this issue 1 year ago • 2 comments

Replaces #3820 Closes #3819 note that the reviewer should manually test.

elibroftw avatar Apr 29 '23 23:04 elibroftw

warnings/errors shown on first launch:

2023-05-02 01:14:46.292	E failed to parse remoteNodesSerialized Error: Cannot assign [undefined] to int
2023-05-02 01:14:46.292	W qrc:/components/RemoteNodeList.qml:0: ReferenceError: label is not defined
[...]
2023-05-02 01:14:46.293	W qrc:/components/RemoteNodeList.qml:107: ReferenceError: label is not defined
[...]

my remote node list now looks like: (after adding a label they do not show) Screenshot from 2023-05-02 02-17-59

creating a new wallet i dont see any of my existing nodes in the suggested list: Screenshot from 2023-05-02 02-21-40

i have not yet tested this PR's functionality todo

i see this is a rebase, thank you

plowsof avatar May 02 '23 01:05 plowsof

I think there's 2 bugs and I think I fixed one of them so check again please.

elibroftw avatar May 02 '23 02:05 elibroftw