monero-gui
monero-gui copied to clipboard
Transfer: display contact name when address is stored in address book
Notes:
- If a single address is used in more than one entry on the addressbook, the descriptions will be separated by comma: "Bob, Bob2"
- Address is displayed in a tooltip. User will be able to review it again on txConfirmationDialog.
Importing from address book adds a third row instead of entering the address in this case. (EDIT: this is unrelated to this PR and exists in current code too)
Import from address book button always try to import to the last recipient line and ignores blank spaces on previous recipient lines. If it's not possible, it will insert a new line (I didn't change this behavior of address book button in PR #3498).
Backtab does not work in this situation
Currently backtab ignores the address field when it contains an address book contact. I prefer it this way. You shouldn't be able to edit the text inserted in address field.
Currently backtab ignores the address field when it contains an address book contact. I prefer it this way. You shouldn't be able to edit the text inserted in address field.
Did you test the situation from the screenshot?
Yes. I get this result, and I think it's ok:
Do you think the contact name should be selected?
Do you think the contact name should be selected?
No it's correct in your GIF, backtab didn't work at all for me but now I can't reproduce it. Will have to play around to see if I can get into this state again.
Now I was able to trigger it again, see how it skips one of the amount fields during backtab:
It's not skipping for me in Ubuntu, with the same fields. Not sure why it's triggered on your computer.
It also does not skip for me on Mac if I restart the GUI. Will write if I figure out how to trigger it.
You could also try something like this to see if the problem is fixed:
MoneroComponents.LineEditMulti {
id: addressInput
KeyNavigation.backtab: index > 0 ? recipientRepeater.itemAt(index - 1).amountInput : sendButton
@rating89us This looks like a great feature, is it still being worked on?