moneriote-python icon indicating copy to clipboard operation
moneriote-python copied to clipboard

Published 20 hours ago • verified publisher icon monero-ecosystem

Check daemon version in scanning

Open Lafudoci opened this issue 6 years ago • 3 comments

This PR is for #8. It's already functional but I'm not sure if I understand the version number right. Review is needed. @skftn @Gingeropolous

Lafudoci avatar Nov 01 '18 17:11 Lafudoci

turns out this may check RPC version and not daemon version. argh.

Gingeropolous avatar Nov 01 '18 19:11 Gingeropolous

@Gingeropolous Really!? So won't it change after protocol upgrade? I couldn't find where is this number produced from.

Lafudoci avatar Nov 02 '18 00:11 Lafudoci

yeah its some kind of RPC version number. It only changes if the RPC rules etc change. I mean, its useful in a sense, because an old RPC version wallet may not work with a new RPC version node... but that is kinda rare and the wallet already handles it (errors out with wrong RPC version or something... this happened with an upgrade a year or so ago).

i think someone will have to actually (gasp) modify the monero source code to create this daemon_version command.

Gingeropolous avatar Nov 02 '18 03:11 Gingeropolous