monorepo-diff-buildkite-plugin
monorepo-diff-buildkite-plugin copied to clipboard
Fatal on upload pipeline failure
Currently, if the resulting Buildkite pipeline fails to upload for any reason (e.g. it attempts to trigger a second pipeline that doesn't exist yet), the build just exits successfully. There's some logging, but this is generally missed since the build doesn't fail.
This PR updates the error check on uploadPipeline
to use log.Fatalf
, which will fail the step if the pipeline can't be uploaded successfully. I can't think of a scenario where it's desirable for this to succeed when the pipeline upload failed.
Resolves #67
@chronotc any opportunity to look at this PR? I think it's a pretty simple enhancement.
fixed by this https://github.com/chronotc/monorepo-diff-buildkite-plugin/pull/102