vibe icon indicating copy to clipboard operation
vibe copied to clipboard

Published 20 hours ago • verified publisher icon mondaycom

RadioButton Typescript Migration

Open orrgottlieb opened this issue 2 years ago • 2 comments

TypeScript here we come! We are migrating to typescript, we are doing so component by component

We would love some help in converting some of our component to typescript - we've created a README https://github.com/mondaycom/monday-ui-react-core/blob/master/TYPESCRIPT_MIGRATION.md

in this PR we expect you to convert the following files

  • [ ] RadioButton.jsx
  • [ ] RadioButtonConstants.js
  • [ ] radioButton-snapshot-tests.jest.js
  • [ ] radioButton-tests.jest.js

Good Luck!

orrgottlieb avatar Oct 02 '22 15:10 orrgottlieb

I would like to work on this @orrgottlieb.

Suman94310 avatar Oct 02 '22 15:10 Suman94310

yes go for it! @Suman94310

orrgottlieb avatar Oct 02 '22 18:10 orrgottlieb

@orrgottlieb I have created a pull request for this.

Suman94310 avatar Oct 04 '22 14:10 Suman94310

@Suman94310 thank you very much, if you have any comments or sugegstions about this package please let me know 🙏

orrgottlieb avatar Oct 07 '22 08:10 orrgottlieb