vibe icon indicating copy to clipboard operation
vibe copied to clipboard

Published 20 hours ago • verified publisher icon mondaycom

Divider Component Typescript Migration

Open orrgottlieb opened this issue 2 years ago • 4 comments

TypeScript here we come! We are migrating to typescript, we are doing so component by component

We would love some help in converting some of our component to typescript - we've created a README https://github.com/mondaycom/monday-ui-react-core/blob/master/TYPESCRIPT_MIGRATION.md

in this PR we expect you to convert the following files

  • [ ] Divider.jsx
  • [ ] DividerConstants.js
  • [ ] divider.jest.js

Good luck!

orrgottlieb avatar Oct 02 '22 08:10 orrgottlieb

Can I work on this issue? @orrgottlieb

aayushbisen avatar Oct 02 '22 11:10 aayushbisen

@aayushbisen of-course you can :) assigned this to you 🙏

orrgottlieb avatar Oct 02 '22 11:10 orrgottlieb

I have a doubt In Divider.jsx is the classname prop optional?

aayushbisen avatar Oct 02 '22 13:10 aayushbisen

@aayushbisen yes

orrgottlieb avatar Oct 02 '22 15:10 orrgottlieb