Checkbox Component Typescript converstion

[orrgottlieb]

TypeScript here we come! We are migrating to typescript, we are doing so component by component

We would love some help in converting some of our component to typescript - we've created a README https://github.com/mondaycom/monday-ui-react-core/blob/master/TYPESCRIPT_MIGRATION.md

in this PR we expect you to convert the following files

• [ ] Checkbox.js
• [ ] useSupportFirefoxLabelClick.jsx
• [ ] checkbox-tests.jest.js
• [ ] checkbox-snapshot-tests.jest.js

Good luck!

[Rahul-Palahwat]

Hey @orrgottlieb it would be great if you assign this issue to me

[orrgottlieb]

@Rahul-Palahwat go for it!

[hadasfa]

Hey @Rahul-Palahwat ! Are you still working on this issue?

[Rahul-Palahwat]

Hey @hadasfa so sorry for delay. Please assign this issue to anyone else

[suvnshr]

Hey @orrgottlieb can I pick this up?

[hadasfa]

@suvnshr You got this! Good luck 🥇

[suvnshr]

Thanks @hadasfa

[hadasfa]

@suvnshr Hey are you still working on this issue?

[suvnshr]

yes, got a busy schedule as of today...will start working on it again tomorrow onwards.

I have some changes left still.

[suvnshr]

@orrgottlieb I have a doubt

Here, isFirefox is imported from user-agent-utils, where it is defined as a simple function.

but isFireFox is also calling a jest function in the same file here.

I'm confused, what type I should assign to isFireFox?

are they supposed to be 2 different variables? one for calling the jest function, and one for that user-agent function?

[kabhamo]

Hi @orrgottlieb, @hadasfa, I hope you are doing well. I noticed that useSupportFirefoxLabelClick.jsx is still not converted to typescript. I have a PR ready to be created with relevant changes for the useSupportFirefoxLabelClick hook file Also, I have tested the functionality and it works as needed, I would be so happy to create a PR for it. Let me know if it is still relevant.

[orrgottlieb]

Hi @kabhamo , Thanks! going over the PR now

[lidoravitan]

is it still opened?

[orrgottlieb]

Hi @lidoravitan, this is done, but we have another great option for you if you want ResponsiveList https://github.com/mondaycom/monday-ui-react-core/blob/master/src/components/ResponsiveList/ResponsiveList.jsx

if you want i can create an issue for you and assign it to you ?

[lidoravitan]

sure let me know what needs to be done on ResponsiveList

[lidoravitan]

@orrgottlieb any update?