vibe icon indicating copy to clipboard operation
vibe copied to clipboard

tooltip_flickering_fix

Open RitikBora opened this issue 1 year ago • 2 comments

This pull request has been raised for the issue #2225 pointed out by Ma1kovich.

When tooltip component hovers over an element (Say Button), and you scroll near the area where the tooltip and the element meet. The tooltip starts to flicker.

I saw in the default moveby offset was {main: 4 , secondary: 0} which was not for enought for all top and bottom tooltips. For the rest is was ok.

So I added a little more main offset to increase the gap between the tooltip and the element for which tooltip is there. This solved the flickering issue for all top and bottom tooltips

I'm attaching a video with the fix for your reference.

https://github.com/user-attachments/assets/bdddb831-b4de-418c-bf3a-58c9aa5c4b53

@talkor let me know your thoughts on this.

Thanks, Ritik

RitikBora avatar Oct 03 '24 08:10 RitikBora

Hey @talkor ,

Thank you for the feedback.

The default prop of {main: 4 , secondary: 0} seemed a little less to me and thats why I modified move by. But I do get your point here . It looks okay on the button but might not look good on some other elements

I'll try out a couple of things here.

  1. Test it out with some smaller elements. Any leads to what all should a try would be appriated :)
  2. Try a different approach where the space between is dynamic and just enough for the tooltip and element to be considered separate .

Let me know if there is anything else you'd like to suggest.

Thanks, Ritik

RitikBora avatar Oct 13 '24 16:10 RitikBora

Hey @talkor ,

Thank you for the feedback.

The default prop of {main: 4 , secondary: 0} seemed a little less to me and thats why I modified move by. But I do get your point here . It looks okay on the button but might not look good on some other elements

I'll try out a couple of things here.

  1. Test it out with some smaller elements. Any leads to what all should a try would be appriated :)

  2. Try a different approach where the space between is dynamic and just enough for the tooltip and element to be considered separate .

Let me know if there is anything else you'd like to suggest.

Thanks,

Ritik

That's awesome @RitikBora, thank you! I'll try to check it out and find some leads as well, and update here 🙏

talkor avatar Oct 13 '24 17:10 talkor

Closing for now, feel free to re-open if relevant again, thanks!

talkor avatar May 11 '25 14:05 talkor