feat!: Vibe 3

[YossiSaadi]

[YossiSaadi]

Writing here so we won't forget We need to merge this not as a squash and merge (!) otherwise we will lose tons of context

[YossiSaadi]

just a short explanation on the latest commits here:

The forced update of the package.json of codemods and icons without really releasing versions for the packages, alongside update to icons and snapshots from master caused the build to get stuck after its tests failed for Tipseen and others

[YossiSaadi]

just a short explanation on the latest commits here:

The forced update of the package.json of codemods and icons without really releasing versions for the packages, alongside update to icons and snapshots from master caused the build to get stuck after its tests failed for Tipseen and others

Still fails, but a bit different issue. For some reason, only on CI, it gets the older version of the icons, and therefore the snapshot test fails, as it gets the old icon svg, instead of the new one. Very strange.

[talkor]

just a short explanation on the latest commits here: The forced update of the package.json of codemods and icons without really releasing versions for the packages, alongside update to icons and snapshots from master caused the build to get stuck after its tests failed for Tipseen and others

Still fails, but a bit different issue. For some reason, only on CI, it gets the older version of the icons, and therefore the snapshot test fails, as it gets the old icon svg, instead of the new one. Very strange.

Sorry @YossiSaadi I had to force push your recent commits, I found the issues:

1. Non-fixated version @vibe/icons in @vibe/core - I changed the version to 1.0.0-rc.0 and removed the ^ as it shouldn't be present in the monorepo's packages.
2. Local issue with @vibe/icon - the src/react and src/lazy folders are ignored by git and are generated on build, and when working locally and switching branches (and running build but not necessarily), these folders are not updated, and so the monorepo takes these folders into account instead of the actual icons on that branch. This may causes some unwanted changes in some snapshots. We need to find a way to resolve it (I'll all for not gitignoring these folders as the overhead of dealing with them otherwise can be frustrating) - @rivka-ungar FYI

[YossiSaadi]

just a short explanation on the latest commits here: The forced update of the package.json of codemods and icons without really releasing versions for the packages, alongside update to icons and snapshots from master caused the build to get stuck after its tests failed for Tipseen and others

Still fails, but a bit different issue. For some reason, only on CI, it gets the older version of the icons, and therefore the snapshot test fails, as it gets the old icon svg, instead of the new one. Very strange.

Sorry @YossiSaadi I had to force push your recent commits, I found the issues:

1. Non-fixated version @vibe/icons in @vibe/core - I changed the version to 1.0.0-rc.0 and removed the ^ as it shouldn't be present in the monorepo's packages.
2. Local issue with @vibe/icon - the src/react and src/lazy folders are ignored by git and are generated on build, and when working locally and switching branches (and running build but not necessarily), these folders are not updated, and so the monorepo takes these folders into account instead of the actual icons on that branch. This may causes some unwanted changes in some snapshots. We need to find a way to resolve it (I'll all for not gitignoring these folders as the overhead of dealing with them otherwise can be frustrating) - @rivka-ungar FYI

Awesome you managed to get it to work!! 🥇

And I don't think we should remove them from the ignore, there's no need for them to be in the repo.

We just need to make sure the build command cleans those folder, no? Or I didn't understand correctly.

[talkor]

just a short explanation on the latest commits here: The forced update of the package.json of codemods and icons without really releasing versions for the packages, alongside update to icons and snapshots from master caused the build to get stuck after its tests failed for Tipseen and others

Still fails, but a bit different issue. For some reason, only on CI, it gets the older version of the icons, and therefore the snapshot test fails, as it gets the old icon svg, instead of the new one. Very strange.

Sorry @YossiSaadi I had to force push your recent commits, I found the issues:

1. Non-fixated version @vibe/icons in @vibe/core - I changed the version to 1.0.0-rc.0 and removed the ^ as it shouldn't be present in the monorepo's packages.
2. Local issue with @vibe/icon - the src/react and src/lazy folders are ignored by git and are generated on build, and when working locally and switching branches (and running build but not necessarily), these folders are not updated, and so the monorepo takes these folders into account instead of the actual icons on that branch. This may causes some unwanted changes in some snapshots. We need to find a way to resolve it (I'll all for not gitignoring these folders as the overhead of dealing with them otherwise can be frustrating) - @rivka-ungar FYI

We just need to make sure the build command cleans those folder, no? Or I didn't understand correctly.

I don't think it's a good practice to clean a folder in the src folder on build 😕

[YossiSaadi]

just a short explanation on the latest commits here: The forced update of the package.json of codemods and icons without really releasing versions for the packages, alongside update to icons and snapshots from master caused the build to get stuck after its tests failed for Tipseen and others

Still fails, but a bit different issue. For some reason, only on CI, it gets the older version of the icons, and therefore the snapshot test fails, as it gets the old icon svg, instead of the new one. Very strange.

Sorry @YossiSaadi I had to force push your recent commits, I found the issues:

1. Non-fixated version @vibe/icons in @vibe/core - I changed the version to 1.0.0-rc.0 and removed the ^ as it shouldn't be present in the monorepo's packages.
2. Local issue with @vibe/icon - the src/react and src/lazy folders are ignored by git and are generated on build, and when working locally and switching branches (and running build but not necessarily), these folders are not updated, and so the monorepo takes these folders into account instead of the actual icons on that branch. This may causes some unwanted changes in some snapshots. We need to find a way to resolve it (I'll all for not gitignoring these folders as the overhead of dealing with them otherwise can be frustrating) - @rivka-ungar FYI

We just need to make sure the build command cleans those folder, no? Or I didn't understand correctly.

I don't think it's a good practice to clean a folder in the src folder on build 😕

It should be from the dist, why src?

[talkor]

just a short explanation on the latest commits here: The forced update of the package.json of codemods and icons without really releasing versions for the packages, alongside update to icons and snapshots from master caused the build to get stuck after its tests failed for Tipseen and others

Still fails, but a bit different issue. For some reason, only on CI, it gets the older version of the icons, and therefore the snapshot test fails, as it gets the old icon svg, instead of the new one. Very strange.

Sorry @YossiSaadi I had to force push your recent commits, I found the issues:

1. Non-fixated version @vibe/icons in @vibe/core - I changed the version to 1.0.0-rc.0 and removed the ^ as it shouldn't be present in the monorepo's packages.
2. Local issue with @vibe/icon - the src/react and src/lazy folders are ignored by git and are generated on build, and when working locally and switching branches (and running build but not necessarily), these folders are not updated, and so the monorepo takes these folders into account instead of the actual icons on that branch. This may causes some unwanted changes in some snapshots. We need to find a way to resolve it (I'll all for not gitignoring these folders as the overhead of dealing with them otherwise can be frustrating) - @rivka-ungar FYI

We just need to make sure the build command cleans those folder, no? Or I didn't understand correctly.

I don't think it's a good practice to clean a folder in the src folder on build 😕

It should be from the dist, why src?

It's both in dist and src. The dist is not an issue, the folders in src are the troublemakers

[rivka-ungar]

just a short explanation on the latest commits here: The forced update of the package.json of codemods and icons without really releasing versions for the packages, alongside update to icons and snapshots from master caused the build to get stuck after its tests failed for Tipseen and others

Still fails, but a bit different issue. For some reason, only on CI, it gets the older version of the icons, and therefore the snapshot test fails, as it gets the old icon svg, instead of the new one. Very strange.

Sorry @YossiSaadi I had to force push your recent commits, I found the issues:

1. Non-fixated version @vibe/icons in @vibe/core - I changed the version to 1.0.0-rc.0 and removed the ^ as it shouldn't be present in the monorepo's packages.
2. Local issue with @vibe/icon - the src/react and src/lazy folders are ignored by git and are generated on build, and when working locally and switching branches (and running build but not necessarily), these folders are not updated, and so the monorepo takes these folders into account instead of the actual icons on that branch. This may causes some unwanted changes in some snapshots. We need to find a way to resolve it (I'll all for not gitignoring these folders as the overhead of dealing with them otherwise can be frustrating) - @rivka-ungar FYI

We just need to make sure the build command cleans those folder, no? Or I didn't understand correctly.

I don't think it's a good practice to clean a folder in the src folder on build 😕

They are folders that are created only on build, would it be bad to delete them right after the dist is created?

[talkor]

just a short explanation on the latest commits here: The forced update of the package.json of codemods and icons without really releasing versions for the packages, alongside update to icons and snapshots from master caused the build to get stuck after its tests failed for Tipseen and others

Still fails, but a bit different issue. For some reason, only on CI, it gets the older version of the icons, and therefore the snapshot test fails, as it gets the old icon svg, instead of the new one. Very strange.

Sorry @YossiSaadi I had to force push your recent commits, I found the issues:

1. Non-fixated version @vibe/icons in @vibe/core - I changed the version to 1.0.0-rc.0 and removed the ^ as it shouldn't be present in the monorepo's packages.
2. Local issue with @vibe/icon - the src/react and src/lazy folders are ignored by git and are generated on build, and when working locally and switching branches (and running build but not necessarily), these folders are not updated, and so the monorepo takes these folders into account instead of the actual icons on that branch. This may causes some unwanted changes in some snapshots. We need to find a way to resolve it (I'll all for not gitignoring these folders as the overhead of dealing with them otherwise can be frustrating) - @rivka-ungar FYI

We just need to make sure the build command cleans those folder, no? Or I didn't understand correctly.

I don't think it's a good practice to clean a folder in the src folder on build 😕

They are folders that are created only on build, would it be bad to delete them right after the dist is created?

I think we should avoid having the build deleting folders from src, can we avoid creating them (and create only in the dist)?

[rivka-ungar]

just a short explanation on the latest commits here: The forced update of the package.json of codemods and icons without really releasing versions for the packages, alongside update to icons and snapshots from master caused the build to get stuck after its tests failed for Tipseen and others

Still fails, but a bit different issue. For some reason, only on CI, it gets the older version of the icons, and therefore the snapshot test fails, as it gets the old icon svg, instead of the new one. Very strange.

Sorry @YossiSaadi I had to force push your recent commits, I found the issues:

1. Non-fixated version @vibe/icons in @vibe/core - I changed the version to 1.0.0-rc.0 and removed the ^ as it shouldn't be present in the monorepo's packages.
2. Local issue with @vibe/icon - the src/react and src/lazy folders are ignored by git and are generated on build, and when working locally and switching branches (and running build but not necessarily), these folders are not updated, and so the monorepo takes these folders into account instead of the actual icons on that branch. This may causes some unwanted changes in some snapshots. We need to find a way to resolve it (I'll all for not gitignoring these folders as the overhead of dealing with them otherwise can be frustrating) - @rivka-ungar FYI

We just need to make sure the build command cleans those folder, no? Or I didn't understand correctly.

I don't think it's a good practice to clean a folder in the src folder on build 😕

They are folders that are created only on build, would it be bad to delete them right after the dist is created?

I think we should avoid having the build deleting folders from src, can we avoid creating them (and create only in the dist)?

I remember that there was some issue when we tried that, I will look into it again