vibe icon indicating copy to clipboard operation
vibe copied to clipboard

Published 20 hours ago • verified publisher icon mondaycom

chore: migrated Dropdown component mondaycom #1622

Open Mila2999 opened this issue 1 year ago • 2 comments

fixes https://github.com/mondaycom/monday-ui-react-core/issues/1622

Basic

  • [ ] Used plop (npm run plop) to create a new component.
  • [ ] PR has description.
  • [ ] New component is functional and uses Hooks.
  • [ ] Component is written in TypeScript.

Style

  • [ ] Styles are added to NewComponent.modules.scss file inside the NewComponent folder.
  • [ ] Component uses CSS Modules.
  • [ ] Design is compatible with Monday Design System.
  • [ ] Styles are defined using monday-ui-style tokens
  • [ ] Displays correctly in all the themes

Storybook

  • [ ] Stories were added to /src/components/NewComponent/__stories__/NewComponent.mdx file.
  • [ ] Stories include all flows of using the component.
  • [ ] Stories implemented using vibe-storybook-components components and tokens.

Tests

  • [ ] Tests are compliant with TESTING_README.md instructions.

Accessibility

Mila2999 avatar Feb 19 '24 17:02 Mila2999

thanks @talkor, i will work on fixing the types

Mila2999 avatar Feb 21 '24 18:02 Mila2999

Hi @talkor , i removed all any references except ref={ref as React.RefObject<any>} . any idea what can i assign to ref?

Mila2999 avatar Feb 22 '24 12:02 Mila2999

Hi @talkor , thank you for your time in reviewing my PR. I have addressed your comments and made the necessary fixes to the code

Mila2999 avatar Apr 05 '24 08:04 Mila2999

@talkor i reverted react-windowed-select from 3.1.0 back to "^2.0.4". to fix typescript errors i added a file and declared a module there, this fixed errors in vs code for me.

Mila2999 avatar Apr 10 '24 12:04 Mila2999

Hey @Mila2999 ! We would like to merge this PR as-is :) we have fixes for mine and @talkor's comments in a different branch you really did brilliant job! would you mind fix the conflict with master so we can merge it?

YossiSaadi avatar May 08 '24 14:05 YossiSaadi

Hi @YossiSaadi,

Thank you! I appreciate the feedback. I have rebased my code onto the master branch and resolved the conflicts in the latest commit. Sorry for any delays, as I'm currently on vacation, but I really would like to finalize this issue.

Mila2999 avatar May 19 '24 01:05 Mila2999

Hi @YossiSaadi,

Thank you! I appreciate the feedback. I have rebased my code onto the master branch and resolved the conflicts in the latest commit. Sorry for any delays, as I'm currently on vacation, but I really would like to finalize this issue.

@Mila2999 thank you so much for the time you put into it! We really appreciate it! 🙏🏼

talkor avatar May 19 '24 07:05 talkor