vibe icon indicating copy to clipboard operation
vibe copied to clipboard

TS-migration: Dropdown

Open SergeyRoyt opened this issue 1 year ago • 16 comments

Monday ticket

Scope of this task is to convert only the main Dropdown file - Dropdown.jsx to typescript Please, check out the Typescript migration guide

SergeyRoyt avatar Oct 08 '23 14:10 SergeyRoyt

I’m interested in this issue

ayeolakenny avatar Oct 08 '23 15:10 ayeolakenny

Assigned to you @ayeolakenny! Good luck with that

SergeyRoyt avatar Oct 08 '23 15:10 SergeyRoyt

Thanks

ayeolakenny avatar Oct 08 '23 15:10 ayeolakenny

Would like to work on this issue is it still open?

Aady7 avatar Oct 11 '23 19:10 Aady7

yes

On Thu, Oct 12, 2023 at 1:05 AM Aditya Pratap Singh < @.***> wrote:

Would like to work on this issue is it still open?

— Reply to this email directly, view it on GitHub https://github.com/mondaycom/monday-ui-react-core/issues/1622#issuecomment-1758406731, or unsubscribe https://github.com/notifications/unsubscribe-auth/BB4P2VSP2WP4OZYG6Z5BU63X63YJLANCNFSM6AAAAAA5XXT3DI . You are receiving this because you commented.Message ID: @.***>

ansumanswain avatar Oct 12 '23 14:10 ansumanswain

@SergeyRoyt assign me the issue

Aady7 avatar Oct 12 '23 16:10 Aady7

Done.

On Thu, Oct 12, 2023 at 10:29 PM Aditya Pratap Singh < @.***> wrote:

@SergeyRoyt https://github.com/SergeyRoyt assign me the issue

— Reply to this email directly, view it on GitHub https://github.com/mondaycom/monday-ui-react-core/issues/1622#issuecomment-1760007591, or unsubscribe https://github.com/notifications/unsubscribe-auth/BB4P2VRGYVWKSKYXXX62KU3X7AOWTAVCNFSM6AAAAAA5XXT3DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRQGAYDONJZGE . You are receiving this because you commented.Message ID: @.***>

ansumanswain avatar Oct 12 '23 20:10 ansumanswain

Hey @ansumanswain ! Don't see your pull request. Please, reference the issue there

SergeyRoyt avatar Oct 15 '23 15:10 SergeyRoyt

Hey, @Aady7! It's assigned to you, if you still want it :)

SergeyRoyt avatar Oct 16 '23 15:10 SergeyRoyt

Thanks will work on it.

Aady7 avatar Oct 16 '23 15:10 Aady7

Hey @ansumanswain! You need to fork our repository

image

For further instruction u'll need to follow this guide https://github.com/mondaycom/monday-ui-react-core/blob/master/CONTRIBUTING.md

If you are still interested I think it's better for you to start with more simple issues - this one might be a bit hard

SergeyRoyt avatar Oct 16 '23 15:10 SergeyRoyt

@SergeyRoyt In this issue I need to change the jsx file to transcript, I guess I will be able to fix it, feel free to assign me some good first issues if they arise. thanks

Aady7 avatar Oct 16 '23 15:10 Aady7

Hey @Aady7! If you've managed to make any progress with the issue, it's better to submit it now, cause Hacktoberfest if coming to the end in a few days 🙏

SergeyRoyt avatar Oct 30 '23 10:10 SergeyRoyt

Still open to contributions if anyone is interested :)

shaharzil avatar Jan 29 '24 09:01 shaharzil

Hi @shaharzil @SergeyRoyt , I would like to work on this issue

Mila2999 avatar Feb 09 '24 11:02 Mila2999

Hi @shaharzil @SergeyRoyt , I would like to work on this issue

Thanks @Mila2999 that would be great!

talkor avatar Feb 14 '24 14:02 talkor