dry icon indicating copy to clipboard operation
dry copied to clipboard

Is there a light theme?

Open NightMachinery opened this issue 6 years ago • 7 comments

The current color scheme looks awful on light-themed terminals.

NightMachinery avatar Sep 05 '19 13:09 NightMachinery

Hi @NightMachinary ,

Sorry there is currently no way to change the color scheme. Could you please share a screenshot of how it looks in a light-themed terminal?

Thanks

moncho avatar Sep 09 '19 21:09 moncho

I second that.... the colors are an issue. Would love to have a light (as in "don't touch my background" :) theme.

I am attaching a screenshot, in case it is still needed. image

DannyBen avatar Oct 22 '19 20:10 DannyBen

Thanks for the screenshot @DannyBen!! It is not pretty, but is not the worse either ;)

As I said there is no support for changing the color scheme for now, but it might be simpler to add way to use the active background color, I will think about it.

moncho avatar Oct 23 '19 12:10 moncho

Perhaps the easiest way to approach this is to a) avoid setting ANY background color and b) avoid using the color white for text. From my experience, if these two guidelines are met, most things look good for everybody.

DannyBen avatar Oct 23 '19 12:10 DannyBen

I'd agree, I have tried it and simply removed the .Background(b) here https://github.com/moncho/dry/blob/595b77677cf3fe7e1da2999aec8ae504ac64dae1/ui/tcell.go#L61

And the result fits in MUCH better with my personal color setup.

Before: Bildschirmfoto 2020-12-05 um 21 22 25

After: Bildschirmfoto 2020-12-05 um 21 22 53

Would be cool if this was the default @moncho

Thanks for this software, its exactly what I needed :)

normen avatar Dec 05 '20 20:12 normen

Thanks for the suggestion, @normen! I have tried it and unfortunately it also removes the background color from the selected items of lists, so it is not enough, sorry.

Great that you like the tool :)

moncho avatar Dec 08 '20 18:12 moncho

Thanks for the suggestion, @normen! I have tried it and unfortunately it also removes the background color from the selected items of lists, so it is not enough, sorry.

Great that you like the tool :)

Hah, sure, it basically removes all background in all styles. I just meant that in general the background should really only be used when needed (i.e. for the CPU use bars etc.) - then it will look fine on most terminals, just as @DannyBen suggested.

normen avatar Dec 08 '20 18:12 normen