clip.cpp icon indicating copy to clipboard operation
clip.cpp copied to clipboard

Fix for build on Windows

Open mdhvg opened this issue 8 months ago • 2 comments

  • This PR fixes issues in the code that could've lead to undefined behaviours
    • Variable-Length Arrays (VLAs), though supported by GCC and Clang, not recommended for use
float vec[vec_len];
// vec_len being a variable set at runtime.
  • Also, the pthread for windows conversion macro from ggml-org/ggml is added to clip.cpp to enable multi-threading support on Windows.

mdhvg avatar Mar 11 '25 07:03 mdhvg

😱 Found 1 issue. Time to roll up your sleeves! 😱

recurseml[bot] avatar Mar 11 '25 07:03 recurseml[bot]

Hi @mdhvg, thanks for raising this PR! I'll review it later today and then merge.

monatis avatar Mar 11 '25 08:03 monatis