owlsim-v3 icon indicating copy to clipboard operation
owlsim-v3 copied to clipboard

Make specific routes for the different matchers

Open cmungall opened this issue 7 years ago • 0 comments

Currently the route is

/match/{matcher}/...

which on the one hand is nice as new matchers can easily be slotted in.

however, different matchers will have different parameterization, and may have differences in payloads. While this could be handled by generic property-value methods, not clear this abstraction is helpful. And it's not like we will have that many matchers in production. Or that it would be hard to add specific routes, it's not that much boilerplate.

It may be clearer to have distinct routes:

  • /match/phenodigm/
  • /match/bnb/

Advantages:

  • distinct swagger documentation for each
  • method-specific parameters are explicit and documented in swagger
  • less guice

cmungall avatar Mar 03 '17 16:03 cmungall