mondo icon indicating copy to clipboard operation
mondo copied to clipboard

update logical axiom for 'lymphocytic choriomeningitis'

Open nicolevasilevsky opened this issue 11 months ago • 5 comments

The current logical axiom is:

'infectious meningitis' and ('disease has primary infectious agent' some NCBITaxon_11623)

but NCBITaxon_11623 is obsolete. The NCBITaxon imports need to be refreshed.

The logical def should be updated to:

'viral meningitis' and ('disease has primary infectious agent' some NCBITaxon_3052303)

https://www.ncbi.nlm.nih.gov/taxonomy/3052303

nicolevasilevsky avatar Feb 27 '24 19:02 nicolevasilevsky

@twhetzel can you import the new NCBI term that is needed?

update - I think I can do it but are these still the current instructions? https://mondo.readthedocs.io/en/latest/editors-guide/import-terms-for-logical-axioms/

cc @sabrinatoro

nicolevasilevsky avatar Mar 04 '24 21:03 nicolevasilevsky

id: NCBITaxon:3052303
name: Mammarenavirus choriomeningitidis
xref: GC_ID:1
synonym: "LCMV" BROAD []
synonym: "Lymphocytic choriomeningitis mammarenavirus" EXACT []
synonym: "Lymphocytic choriomeningitis virus" EXACT []
synonym: "lymphocytic choriomeningitis virus LCMV" EXACT []

cmungall avatar Mar 05 '24 01:03 cmungall

I'll try those instructions @nicolevasilevsky

twhetzel avatar Mar 05 '24 03:03 twhetzel

I added "http://purl.obolibrary.org/obo/NCBITaxon_3052303" into "imports/ncbitaxon_terms.txt" and then ran sh run.sh make refresh-merged and included the updated files in https://github.com/monarch-initiative/mondo/pull/7370 based on steps listed in the docs.

Please confirm these steps are correct.

twhetzel avatar Mar 05 '24 05:03 twhetzel

In Slack, @matentzn mentioned this are part of the correct steps but that this taxon needs to be added to another file. I submitted an issue for this: https://github.com/obophenotype/ncbitaxon/issues/100

I don't know if it's ok to merge this PR as-is.

twhetzel avatar Mar 05 '24 18:03 twhetzel