monarch-ui icon indicating copy to clipboard operation
monarch-ui copied to clipboard

add ribbon to monarch

Open nathandunn opened this issue 5 years ago • 7 comments

There was some discussion about doing this. Not sure when it happens, but wanted a placeholder for it.

https://github.com/geneontology/ribbon

nathandunn avatar Aug 31 '18 21:08 nathandunn

@monicacecilia is this issue still active?

pnrobinson avatar Jul 10 '19 11:07 pnrobinson

@pnrobinson Not that I am aware of. I have not heard about any plans for implementation in the past 7 months, so I assume - as pointed out by Nathan above - that there is no urgency with this at all.

I am inclined to think that the current UI plans are moving in a different direction and this issue could be tabled for the foreseeable future; that's why it does not have a neither a milestone nor a project attached to it.

monicacecilia avatar Jul 16 '19 23:07 monicacecilia

This might be a good @cmungall question, as well.

What is currently in the AGR also uses biolink for GO, the same as monarch, but can be used for phenotypes, multi-organism, etc. It wouldn't be hard to integrate (would probably be @lpalbou doing most of the work).

nathandunn avatar Jul 17 '19 00:07 nathandunn

per the monarch meeting, this is again of interest

kshefchek avatar Nov 08 '19 01:11 kshefchek

we talked about identifying the set of upheno upper terms, and possibly color coding them and the table.

mellybelly avatar Nov 08 '19 01:11 mellybelly

The ribbon has evolved a lot in the last year and most classes in the repo will be deprecated. What is integrated in the alliance and used for both GO/Expression/Disease is in that folder: https://github.com/geneontology/ribbon/tree/master/src/components . And we use a new data model to create & fill the ribbon strips (e.g. GO Ribbon Summary API)

However, I have started working on the web component version, that will follow the same data model. It will be easy to integrate in monarch as it will be a matter of loading the script and setting correctly some attributes.

Do you plan / want to use the ribbon only for go annotations or for other annotations as well ?

lpalbou avatar Nov 22 '19 19:11 lpalbou

@lpalbou We had talked briefly with @cmungall about potentially adding phenotypes as well if the API calls will still align.

nathandunn avatar Nov 22 '19 20:11 nathandunn