monarch-ui icon indicating copy to clipboard operation
monarch-ui copied to clipboard

Create a new Phenotype Curation Guidelines page

Open monicacecilia opened this issue 5 years ago • 13 comments

  • [ ] Using the guidelines as they were published on the latest Current Protocols paper (here), create a new page titled 'Phenotype Curation Guidelines.'
  • [ ] In the top-level menu 'Documentation,' replace current link out to blog post on medium with this new page under the 'Phenotype Curation Guidelines' submenu.

monicacecilia avatar Aug 21 '19 17:08 monicacecilia

  • [ ] Path for the new page should be /documentation/curationguidelines

monicacecilia avatar Aug 21 '19 23:08 monicacecilia

I think this should be on the HPO webpage for the clinical guidelines. I think that unfortunately we need to wait a year for the article to go onto PMC. Also note that it is premature to talk about curation guidelines (we are the ones doing it!) and the article is talking about annotating individuals.

pnrobinson avatar Aug 23 '19 12:08 pnrobinson

Ticket issued by @mellybelly's suggestion. Tagging here to get her attention to address @pnrobinson's valid points.

monicacecilia avatar Aug 23 '19 15:08 monicacecilia

@pnrobinson there used to be a monarch blog I wrote that had the patient-level curation guidelines from the UDP, this is not about HPO disease curation. I think the page should be posted in both sites, but what Moni and I were brainstorming was an update from the blog, especially since users won't be able to get to the current protocols manuscript.

mellybelly avatar Aug 23 '19 15:08 mellybelly

This is the blog post currently linked from Documentation top level menu, in the submenu item Phenotype Curation Guidelines. This page was moved from monarch-app (legacy site) to monarch-ui (new, beta site).

monicacecilia avatar Aug 23 '19 15:08 monicacecilia

@monicacecilia where do you want me to put the content?

mellybelly avatar Aug 25 '19 18:08 mellybelly

@mellybelly You will need to create a new 'Phenotype Curation Guidelines" page with the content you want to add. If you have already cloned the repo, please create the new markdown file at /src/views and make a pull request. Else, perhaps you could provide us with a mock up of the page you envision having, and share the file(s) with us. If so, we can ask @iimpulse to please work on this new page once you provide the content.

monicacecilia avatar Aug 27 '19 03:08 monicacecilia

https://github.com/monarch-initiative/monarch-ui/tree/feature/phenotype-guidelines

The branch is here with the page under src/views/PhenotypeCurationGuidelines.md

I've added the blog post for now and you can update accordingly. This also has a hotfix for the node page banner.

iimpulse avatar Aug 29 '19 20:08 iimpulse

I am worried that we should not have two competing versions of this material, and currently there is a lot of documentation related to this on the HPO site. Can we make a shorter version here and link to the HPO site? The HPO site needs to have a link to the new Protocols paper. Also, we should consider talking about guidelines for model curation that will go here.

pnrobinson avatar Aug 29 '19 20:08 pnrobinson

Currently, the link for 'Phenotype Curation Guidelines' is a re-direct to the blog Melissa wrote on Medium, five years ago.

Earlier in this ticket:

  • @pnrobinson proposed to make a shorter version of this page [on the Monarch UI] and link to the HPO site
  • @mellybelly had concerns that the patient-level curation guidelines from the UDP, [are] not about HPO disease curation and that she would like to update the Monarch Blog entry she wrote about it and place that content in this page instead.

@pnrobinson, @mellybelly, may I kindly ask that you please decide on what would be the best course of action and share the response (and preferred content) with us? We are down to the wire now and need to figure out what to do with this page.

Thank you!

monicacecilia avatar Feb 03 '20 02:02 monicacecilia

Can we revisit after the proposal is out the door? I think we will want to add a lot more stuff and so we could just leave things as they are for now and plan to come back to this when we have time

pnrobinson avatar Feb 03 '20 12:02 pnrobinson

I like the sound of that. We can come back to revisit at a later time. It won't be show stopper for release, then. Thank you, @pnrobinson.

monicacecilia avatar Feb 06 '20 00:02 monicacecilia

Proposals are out the door, and we're itching for a v1.0 release (in approximately 1 week). In the absence of activity on this ticket, I'm making a decision to punt it to a future enhancement sprint, after v1.0 is out the door.

monicacecilia avatar Mar 06 '20 08:03 monicacecilia