dipper icon indicating copy to clipboard operation
dipper copied to clipboard

add BioPlex PPI data

Open nlwashington opened this issue 9 years ago • 0 comments

There's a new set of data out for PPI. We should fetch these, which are for human interactions.

http://wren.hms.harvard.edu/bioplex/downloadInteractions.php

nlwashington avatar Jul 29 '15 17:07 nlwashington

So here's a wireframe for discussion purposes. Any thoughts? I've overlaid on the homepage screenshot so you can get a sense of scale. We can:

  1. Move HPO up to the top and move phenogrid down or
  2. Keep phenogrid up top and move HPO down

In either case, the news feed would follow below those two.

At least during this phase of announcements coming up, I favor option 1. Thoughts?

@cmungall @mellybelly?

hpo-cameo

FYI these are wikimedia images, so we would need to attribute accordingly. Does cropping constitute alteration? In any case, looking to @DoctorBud as to how to convey this attribution in a sensible way.

term File License
Aperts Syndrome wikipedia CC-BY 2.0
Syndactyly wikipedia gnu free documentation license
Craniosynostosis wikipedia CC 3.0 share alike.

Looking also to @pnrobinson regarding this use case. Eg. to make sure that this specific form of syndactyly depicted is plausible in Apert's.

jmcmurry avatar Mar 23 '16 19:03 jmcmurry

I would also like to have whichever cameo is up top extend further vertically to avoid this kind of frame misalignment. screen shot 2016-03-23 at 12 58 46 pm

jmcmurry avatar Mar 23 '16 19:03 jmcmurry

few comments: maybe add HPO icon, could be built into HPO project button, or somewhere else maybe change title of layperson synonyms announcement to something more exciting, Layperson synonyms are here! or somesuch. I like the examples. I'd put HPO at the top, especially with the imminent layperson release.

mellybelly avatar Mar 24 '16 00:03 mellybelly

@mellybelly now up on beta.monarchinitiative.org; https://github.com/monarch-initiative/monarch-app/pull/1211

I suggested making the header clickable too and replacing image with one that has a lighter border. Any other changes?

jmcmurry avatar Mar 25 '16 03:03 jmcmurry

I think this looks great. there is a slight misalignment of the blocks in the right column with the other blocks on the left two columns but its not really a big deal.

mellybelly avatar Mar 25 '16 03:03 mellybelly

will the link be updated? (i.e. links to the blog-post about peters price)

drseb avatar Mar 25 '16 06:03 drseb

+1 I think this looks great. I just posted the blog post about the hpo synonyms, @drseb, I'm sure Julie will update the link. :)

@jmcmurry here is the link, so it's handy for you: http://monarch-initiative.blogspot.com/2016/03/finally-medical-terminology-that.html

nicolevasilevsky avatar Mar 25 '16 16:03 nicolevasilevsky

@mellybelly the misalignment of blocks between the left 2 columns and the right columns changes as you resize the window horizontally. The asymmetric layout is an artifact of the Twitter feed's limited width and the carousel; I hate it and would love to reorg the landing page, but was trying to focus on getting the HPO news out.

I'm updating the link to use the one provided by @nicolevasilevsky above. Should we have links to both blog posts:

  • http://monarch-initiative.blogspot.com/2016/02/european-rare-disease-organization.html
  • http://monarch-initiative.blogspot.com/2016/03/finally-medical-terminology-that.html

[Default: We'll just point to the more recent one]

@jmcmurry when you say make the header clickable, do you mean the panel header? where we have the words 'New: Plain language for describing human diseases'? That's not intended to be a button, but I can make it one. Where should it link to? HPO site or blog site?

[Default: Turn header TEXT (not the whole panel header) into a link to the most recent blog post]

I will remove the image border and replace it with a CSS border. I was thinking lightgray, 1px thick.

DoctorBud avatar Mar 25 '16 22:03 DoctorBud

Latest looks like this... Waiting on feedback before making a PR of it...

untitled

DoctorBud avatar Mar 25 '16 23:03 DoctorBud

Looks great!! Small thing: Not sure about the lay synonym for craniosynonstosis, should it not be skull deformity due to premature suture closure?

pnrobinson avatar Mar 26 '16 08:03 pnrobinson

I wasn't sure whether suture was lay-friendly enough. Can you think of a better word?

jmcmurry avatar Mar 28 '16 17:03 jmcmurry

Nicole V's suggestion of 'Deformity due to premature fusing of skull bones’ seems good!

pnrobinson avatar Mar 29 '16 06:03 pnrobinson

@DoctorBud I think this looks good! I like the label 'plain language' (to whoever came up with that).

nicolevasilevsky avatar Mar 29 '16 17:03 nicolevasilevsky

+1

mellybelly avatar Mar 29 '16 17:03 mellybelly

Here's the latest look for the cameo section, incorporating the new blog post link and Julie's new image:

hpocameopic

DoctorBud avatar Mar 31 '16 01:03 DoctorBud

Links go to either HPO or the March 25 blog post

DoctorBud avatar Mar 31 '16 01:03 DoctorBud

Is there any room for changing the text? The synonyms aren't any more machine comprehensible than the original terms, are they? If the "plain language" is intended to be comprehensible by people without biomedical training, just say "..includes synonyms explaining medical terms in non-technical language."

harryhoch avatar Mar 31 '16 01:03 harryhoch

Changing the text currently requires Julie generate a new graphic with text in it. If we have another iteration where we want new words, I suggest biting the bullet and building the HPO Cameo table via HTML/CSS instead of Photoshop. That would simplify future changes to the text.

Meanwhile, I'm going to proceed with my PR https://github.com/monarch-initiative/monarch-app/pull/1217, although I'm currently encountering issues with Travis tests failing to install the right version of Node.

DoctorBud avatar Mar 31 '16 11:03 DoctorBud

ouch. yes, please to HTML/CSS instead of Photoshop. Embedding text in an image like that is ugly in many ways.

harryhoch avatar Mar 31 '16 11:03 harryhoch

@jmcmurry slightly tangential, but it might be good to generally avoid GNU FDL images texts, as they can easily cause various issues and incompatibilities--they are not considered to meet DFSG, and not even particularly compatible with other GNU licensing.

kltm avatar Jun 03 '16 23:06 kltm