Monal icon indicating copy to clipboard operation
Monal copied to clipboard

[Feature]: Allow custom sounds per sender

Open tmolitor-stud-tu opened this issue 1 year ago • 4 comments

Precondition

  • [X] I understood that this template is only for feature requests and not for bug reports

Cross-checked related issues?

  • [X] I have cross-checked this overview https://github.com/monal-im/Monal/issues/322 as well as filtered for related labels https://github.com/monal-im/Monal/labels

Describe your feature

Rewrite the current sound picker using SwiftUI.

The user should be able to pick different sounds for different senders, just like the SwiftUI implementation of the background image allows different images for different senders.

tmolitor-stud-tu avatar Jan 15 '24 15:01 tmolitor-stud-tu

I am eager to participate in Monal's Google Summer of Code 2024 project this year. To prepare adequately, Could you please assign me to tasks related to the Monal project? I am committed to delivering my best and will adhere to all guidelines and requirements.

guodong323 avatar Mar 01 '24 19:03 guodong323

For all interested in participating in GSOC, I wrote a quick "how to" checklist over at our wiki: https://github.com/monal-im/Monal/wiki/GSOC-2024-Guidline

tmolitor-stud-tu avatar Mar 02 '24 19:03 tmolitor-stud-tu

MLSoundsTableViewController: Implement the SoundsSettingView.swift using List in SwiftUI.

In ContactDetails.swift, add a new NavigationLink below the Text("Change Chat Background") that includes a Text("Change Chat Sound") and navigates to SoundsSettingView.swift.

Logic section:

In SoundsSettingView.swift, use AVAudioPlayer to play the sound corresponding to the selected index.

When a sound is selected, save the corresponding sound to UserDefaults, and Key is user's contactJid + "AlertSoundFile"

guodong323 avatar Mar 06 '24 19:03 guodong323

@guodong323 does closing your PR mean you don't want to work on this anymore or do you want to create a fresh PR instead?

tmolitor-stud-tu avatar Mar 19 '24 00:03 tmolitor-stud-tu