moment-timezone icon indicating copy to clipboard operation
moment-timezone copied to clipboard

"Asia/Calcutta" added for ios

Open mahipalsingh-syt opened this issue 4 years ago • 2 comments

mahipalsingh-syt avatar Jul 31 '20 09:07 mahipalsingh-syt

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

jsf-clabot avatar Jul 31 '20 09:07 jsf-clabot

The data used by Moment Timezone comes from the IANA time zone database and is re-compiled for each database release. Therefore any changes to the latest.json file in a PR will be overwritten by the next release.

In this specific case, the Asia/Calcutta zone is a only link (alias) to the primary zone of Asia/Kolkata (after the city changed its official English spelling). This is why it doesn't appear in the meta data file, which only lists primary zones, not links.

You mentioned this is for iOS — is this related to the moment.tz.guess() API? I know there are some browsers that return Asia/Calcutta instead of Asia/Kolkata when asked for their user time zone.

gilmoreorless avatar Jan 19 '21 10:01 gilmoreorless

Thank you @gilmoreorless for getting to the bottom of this.

ichernev avatar Aug 28 '22 06:08 ichernev