moment-timezone icon indicating copy to clipboard operation
moment-timezone copied to clipboard

Published 20 hours ago • verified publisher icon moment

Zone._index optimization: binary search for closest "until"

Open dashie opened this issue 6 years ago • 4 comments

dashie avatar Jan 28 '19 14:01 dashie

Hi @dashie. Sorry I was tuned out for a while.

You basically hit the same problem I just stumbled upon, in #743 after updating things for the latest IANA version.

Would you be so kind to rebase this off the current release?

Thanks.

mattjohnsonpint avatar Apr 18 '19 22:04 mattjohnsonpint

... Or rather, can you separate the code changes out so I can do a full build after merging?

Thanks.

mattjohnsonpint avatar Apr 18 '19 22:04 mattjohnsonpint

I did it, but there are always issues with IANA version. Anyway I've cleaned and rebased my history (https://github.com/dashie/moment-timezone/commit/fa5c4b69b6e42760a3dcc8f818e921759e7e604d) so it is simple for you to look into the changes

dashie avatar Apr 20 '19 03:04 dashie

Ooh, binary search, nice. I hope to merge this soon.

ichernev avatar Aug 28 '22 07:08 ichernev

it is merged now?

dashie avatar Dec 09 '22 18:12 dashie