MOM5 icon indicating copy to clipboard operation
MOM5 copied to clipboard

Published 20 hours ago • verified publisher icon mom-ocean

npp diagnostics are incorrect

Open aekiss opened this issue 2 years ago • 3 comments

As noted in https://github.com/hrsdawson/ACCESS-WOMBAT_01deg_BGC_validation/issues/3#issuecomment-1341898663, the diagnostic npp3d is calculated incorrectly (it's phytoplankton growth (f11) minus grazing (f21), but should be phytoplankton growth minus linear mortality (f22)).

https://github.com/mom-ocean/MOM5/blob/5126b546f1e386b6d6dcf8a62e23af692055aa92/src/mom5/ocean_csiro_bgc/bio_v3.inc#L347-L348

We could fix this by replacing f21 (grazing) with f22 (linear mortality).

aekiss avatar Feb 15 '23 02:02 aekiss

This bug also affects the diagnostics that are derived from npp3 (npp1, npp2d, npp_intmld, npp_int100)

aekiss avatar Feb 15 '23 02:02 aekiss

@hakaseh should I fix his while we're at it?

aekiss avatar Mar 23 '23 05:03 aekiss

yes, I thought about that too. Based on the discussion from https://github.com/COSIMA/access-om2/issues/272, should we consider pprod_gross as NPP ?

hakaseh avatar Mar 23 '23 06:03 hakaseh