MOM5 icon indicating copy to clipboard operation
MOM5 copied to clipboard

Incorrect units for tracer flux and tendency diagnostics

Open aekiss opened this issue 3 years ago • 0 comments

It looks like non-temperature tracer fluxes and tendencies are given generic units that don't take into account the units of the tracer (ie it is assumed the tracer is dimensionless): https://github.com/mom-ocean/MOM5/blob/b68f137d51f7b0e7fb53cdeafc54723d68a50ed2/src/mom5/ocean_tracers/ocean_tracer_advect.F90#L870-L929

So for example BGC advective flux terms get the wrong units.

e.g. adic_xflux_adv, eg /g/data/ik11/outputs/access-om2-01/01deg_jra55v140_iaf_cycle4/output882/ocean/oceanbgc-3d-adic_xflux_adv-1-monthly-mean-ym_1991_07.nc has

    long_name:      rho*dzt*dyt*u*tracer
    units:          kg/sec

but the adic tracer /g/data/ik11/outputs/access-om2-01/01deg_jra55v140_iaf_cycle4/output882/ocean/oceanbgc-3d-adic-1-monthly-mean-ym_1991_07.nc has

    long_name:      natural + anthropogenic dissolved inorganic carbon
    units:          mmol/m^3

If the adic_xflux_adv long_name is correct, the adic_xflux_adv units should be (mmol kg)/(m^3 sec)~, which is roughly mol/sec~.

Maybe generic units for _xflux_adv should be given as (tracer units)*kg/sec. Similarly for the other fluxes, tendencies etc.

aekiss avatar Feb 10 '22 21:02 aekiss