BinaryCIF icon indicating copy to clipboard operation
BinaryCIF copied to clipboard

Unclarities in specification

Open padix-key opened this issue 1 year ago • 2 comments

While implementing a BinaryCIF file interface and I found some parts of the specification ambiguous:

  • What are the integer values a mask can hold and how do they map to the cif values (. and ?)
  • Is the final offset in a String Arraythe exclusive stop or a start index itself?
  • When encoding using Interval Quantization, are the values assigned to the closest step or to the next lower/higher step?
  • Into which data type does Delta encode?
  • How are the data types mapped to integers?

padix-key avatar Feb 02 '24 16:02 padix-key

My reading of the code is that ciftools-python 0 = data, 1 = ., 2 = ?

Molstar/src/mol-data/db/column.ts: 0 = present, 1= ., 2 = ?

Also - lack of mask should be None -- not {}

epeisach avatar Feb 04 '24 23:02 epeisach

Thanks. I my opinion such details should be part of the specification itself.

padix-key avatar May 13 '24 11:05 padix-key

Sorry for the late reply. You are right, this should be mentioned in the specification -- I will add it.

dsehnal avatar Oct 14 '24 12:10 dsehnal