fwdpy11 icon indicating copy to clipboard operation
fwdpy11 copied to clipboard

Genetic value API

Open molpopgen opened this issue 1 year ago • 2 comments

Recent discussions elsewhere demonstrate that the specification of the genetic value objects is confusing. Specifically, the ndemes field is a kludge.

Ideally, gvalue would be a list of one object per deme. The dimensionality of each object has to line up with the dimensionality of the effect size distribution. In other words, multi-deme models with pleiotropy** and multi-deme models with correlated effect sizes across demes need to be conceptually unified.

**do we even support this?

molpopgen avatar Nov 11 '23 19:11 molpopgen

"Warning": any change to this requires mucking around on the C++ side.

molpopgen avatar Nov 12 '23 18:11 molpopgen

To avoid breaking API we'd have to deprecate the current ndemes argument.

molpopgen avatar Nov 12 '23 18:11 molpopgen