Kevin R. Thornton

Results 90 comments of Kevin R. Thornton

I didn't get around to firing up my Mac yet. It isn't my daily driver and I am easily distracted!

Then I'd say that it is the docs that are wrong here: the default is None, not 2, and the behavior is to use 2 if the default is passed...

> Yes the docstring could be clearer here, some thing like "if no ploidy is specified 2 is used" rather than "(Default=2)" Yes, that would be better. Personally, I see...

Shall we clarify the doc string a bit then?

One thought experiment is: what if some app using tskit is already generating all site positions on 1

> That wouldn't be a valid tree sequence as all positions have to be less than sequence length. Oops -- it would be if I'd written it correctly (w/o the...

> I'm not sure I get what you mean - you can have a tree sequence with no sites? Maybe you mean we have no firm specification for how the...

I think my questions/confusion are related to some comments in the linked issue: seqlen must be > the max allowed position but the data model is not necessarily zero indexed....

It doesn't affect anything. The rust build works by compiling tskit-c and then grabbing the public API into a namespace. So as long as all things in header files remain...

@mencian -- any idea what is going on here? The last several releases have been missed and, to me, the errors are inscrutable.