tabnabbing-demo icon indicating copy to clipboard operation
tabnabbing-demo copied to clipboard

Published 20 hours ago • verified publisher icon molnarg

Link not opening in new tab

Open aaronkelton opened this issue 5 years ago • 2 comments
trafficstars

I'm using Chrome Version 78.0.3904.87 (Official Build) (64-bit)

When I click the link in the Readme, it doesn't open in a new tab. Closing the tab then defeats the purpose, and navigating back doesn't demonstrate anything either.

Right-clicking to open in new tab also doesn't perform the intended phenomenon in the original tab. Does anything for this demo need to be updated, or has GitHub / Chrome updates rendered this demo obsolete?

aaronkelton avatar Jan 15 '20 18:01 aaronkelton

It seems like GitHub no longer opens links in new tab: links don't have target="_blank" attribute. If you edit the DOM in the browser dev tools and add it back, it still works. Right click -> open in new tab doesn't seem to set window.opener, so that's not vulnerable.

molnarg avatar Feb 03 '20 19:02 molnarg

@molnarg i added target _blank by editing the DOM directly. window.opener is still null. Are browsers handling this properly now already?

chirag04 avatar Mar 02 '21 16:03 chirag04