Gábor Molnár

Results 40 comments of Gábor Molnár

This is one of the last items on my TODO list so feel free to pick this up if you are interested :) It shouldn't be hard to implement given...

Agreed. If someone implements this in a clean way, I may merge it, but don't plan to put any effort into it.

Thanks for reporting. This would indeed be nice. I expect to have some time to look into this in about a week. Feel free to send pull requests if you...

Thanks for digging deeper! I don't have an idea for a fix yet, but will be thinking about possible solutions...

In node-http2, all of the features can be implemented without relying on inheritance, even without performance loss. Both the IncomingMessage class and inheriting from PassThrough is just convenience, they are...

So, although IncomingMessage and PassThrough are avoidable, both IncomingRequest and IncomingResponse are necessary (or avoidable only with performance penalty). And the protos belonging to these classes would be replaced by...

I would be happy with 5.0 as a solution without support for 4.x. But, what do you mean by prototype injection? If it is `var originalPrototype = req.__proto__; req.__proto__ =...

Yeah, it's pretty tricky to implement this thing properly. If express is going to do something like this, then I think both http2 and http1 would work: maintain a map...

Yes if the map is static. But it could start as empty (or preloaded with the builtin http1 IncomingMessage), and dynamically filled up with proto->injectable_proto mappings as new protos are...

Waiting for the spec to specify how it should work...